add timeout for page.content() #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to df3f712 in 38 seconds
More details
- Looked at
85lines of code in3files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/constants.py:10
- Draft comment:
The comment forPAGE_CONTENT_TIMEOUTincorrectly states "5 mins" when the actual timeout is set to 300 milliseconds. Please correct the comment to reflect the accurate duration.
+PAGE_CONTENT_TIMEOUT = 300 # 300 milliseconds
- Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_CadMkGLqK0cOZa6I
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Introduced a timeout for the
page.content()method by adding aget_page_contentfunction with a timeout parameter and updating relevant methods to use it.Key points:
PAGE_CONTENT_TIMEOUTconstant (300 seconds) inskyvern/constants.py.get_page_contentfunction inskyvern/webeye/scraper/scraper.pywith a timeout parameter.record_artifacts_after_actionmethod inskyvern/forge/agent.pyto useget_page_content.scrape_web_unsafefunction inskyvern/webeye/scraper/scraper.pyto useget_page_contentwith error handling.Generated with ❤️ by ellipsis.dev